[Lldb-commits] [lldb] [lldb/crashlog] Implement speculative binary lookup for target creation (PR #154975)

[Jonas Devlieghere via lldb-commits]

https://github.com/JDevlieghere requested changes to this pull request.

I don't think it's appropriate for the crashlog script to recursive through someone's home directory. This is going to result in TCC (Transparency Consent and Control) popups when trying to access certain directories (like Photos, Downloads, etc). That's by design and a good indication that this isn't a good idea. As a user, if I saw a script/program do this without my explicit direction to do so, I would be very unhappy.  

Potential alternatives that I think are fine:

- Replacing `/Users/USER` by `~` but presumably everything after is stripped to, which is why you're doing this in the first place. 
- Using mdfind to find the dSYM for the binary, and looking next to it, similar to what LLDB does. 
- Relying on `dsymForUUID` to give you the symbol rich executable. 

https://github.com/llvm/llvm-project/pull/154975