[Lldb-commits] [lldb] 5abad32 - Revert "[lldb] Fix error : unknown error while starting lldb's C/C++ repl (#153560)"
Shubham Sandeep Rastogi via lldb-commits
lldb-commits at lists.llvm.org
Tue Aug 19 08:35:12 PDT 2025
Author: Shubham Sandeep Rastogi
Date: 2025-08-19T08:34:29-07:00
New Revision: 5abad32538d4aa6fa9a418d9dfe74d2fd275efd7
URL: https://github.com/llvm/llvm-project/commit/5abad32538d4aa6fa9a418d9dfe74d2fd275efd7
DIFF: https://github.com/llvm/llvm-project/commit/5abad32538d4aa6fa9a418d9dfe74d2fd275efd7.diff
LOG: Revert "[lldb] Fix error : unknown error while starting lldb's C/C++ repl (#153560)"
This reverts commit 00ffd8b8aa4e8cd3a2fee654d55995918886e874.
The change breaks lldb greendragon tests
Namely, TestClangREPL.py
Added:
Modified:
lldb/source/Commands/CommandObjectExpression.cpp
lldb/test/API/repl/clang/TestClangREPL.py
Removed:
################################################################################
diff --git a/lldb/source/Commands/CommandObjectExpression.cpp b/lldb/source/Commands/CommandObjectExpression.cpp
index 41bc8abf4897f..197bffe9c982f 100644
--- a/lldb/source/Commands/CommandObjectExpression.cpp
+++ b/lldb/source/Commands/CommandObjectExpression.cpp
@@ -640,15 +640,9 @@ void CommandObjectExpression::DoExecute(llvm::StringRef command,
repl_sp->SetValueObjectDisplayOptions(m_varobj_options);
}
- if (!expr.empty()) {
- result.GetOutputStream().Printf(
- "Warning: trailing input is ignored in --repl mode\n");
- }
-
IOHandlerSP io_handler_sp(repl_sp->GetIOHandler());
io_handler_sp->SetIsDone(false);
debugger.RunIOHandlerAsync(io_handler_sp);
- return;
} else {
repl_error = Status::FromErrorStringWithFormat(
"Couldn't create a REPL for %s",
diff --git a/lldb/test/API/repl/clang/TestClangREPL.py b/lldb/test/API/repl/clang/TestClangREPL.py
index 3152018865b1e..97d91d1b8f7a5 100644
--- a/lldb/test/API/repl/clang/TestClangREPL.py
+++ b/lldb/test/API/repl/clang/TestClangREPL.py
@@ -56,16 +56,6 @@ def test_basic_completion(self):
self.quit()
- # Re-enter the REPL with trailing input to trigger warning.
- self.child.send("expression --repl -l c -- 3 + 3\n")
- self.child.expect_exact("Warning: trailing input is ignored in --repl mode\n")
- self.child.expect_exact("1>")
-
- # Evaluate another expression after warning.
- self.expect_repl("4 + 4", substrs=["(int) $3 = 8"])
-
- self.quit()
-
# PExpect uses many timeouts internally and doesn't play well
# under ASAN on a loaded machine..
@skipIfAsan
More information about the lldb-commits
mailing list