[Lldb-commits] [lldb] [lldb] Call FixUpPointer in WritePointerToMemory (try 2) (PR #153585)

David Spickett via lldb-commits lldb-commits at lists.llvm.org
Thu Aug 14 07:45:25 PDT 2025


================
@@ -640,6 +640,13 @@ void IRMemoryMap::WritePointerToMemory(lldb::addr_t process_address,
                                        lldb::addr_t address, Status &error) {
   error.Clear();
 
+  /// Only ask the Process to fix the address if this address belongs to the
+  /// process (host allocations are stored in m_data).
----------------
DavidSpickett wrote:

This is missing a "because...".

Even though that reason will lead most people to wonder why we fix pointers written into the process given that they could be running on the same host but ok - larger issue as we discussed before.

https://github.com/llvm/llvm-project/pull/153585


More information about the lldb-commits mailing list