labath wrote: There's still too much auto in the patch. Particularly those that hide llvm::Expected are dangerous. Apart from that, and despite the number of comments, I think this is pretty good. https://github.com/llvm/llvm-project/pull/152308