[Lldb-commits] [lldb] [lldb] Refactoring JSONTransport into an abstract RPC Message Handler and transport layer. (PR #153121)

[Jonas Devlieghere via lldb-commits]

================
@@ -344,13 +346,14 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name,
   bool client_failed = false;
   {
     std::scoped_lock<std::mutex> lock(dap_sessions_mutex);
-    for (auto [sock, dap] : dap_sessions) {
+    for (auto [loop, dap] : dap_sessions) {
       if (llvm::Error error = dap->Disconnect()) {
         client_failed = true;
-        llvm::errs() << "DAP client " << dap->transport.GetClientName()
-                     << " disconnected failed: "
+        llvm::errs() << "DAP client disconnected failed: "
----------------
JDevlieghere wrote:

Since you're here:
```suggestion
        WithColor::error() << "DAP client disconnected failed: "
```

https://github.com/llvm/llvm-project/pull/153121