[Lldb-commits] [lldb] [lldb] Make StackID call Fix{Code, Data} pointers (PR #152796)

[Jason Molenda via lldb-commits]

https://github.com/jasonmolenda approved this pull request.

This LGTM.  Yes, I think lldb currently has a mix of "clean metadata bits when we first see an address" and "clean metadata bits before using" (e.g. Process::ReadMemory), and we should have a discussion about whether we should keep a mix of input-time and use-time clearing of bits, or if we should switch to only clearing them at use-time and maintaining metadata until that point.  But this brings StackID in line with other use-time clearings, it's a straightforward change.

https://github.com/llvm/llvm-project/pull/152796