[Lldb-commits] [lldb] [lldb] Guard SBFrame/SBThread methods against running processes (PR #152020)

[Felipe de Azevedo Piovezan via lldb-commits]

================
@@ -566,6 +559,53 @@ class ExecutionContext {
   lldb::StackFrameSP m_frame_sp; ///< The stack frame in thread.
 };
 
+/// A wrapper class representing an execution context with non-null Target
+/// and Process pointers, a locked API mutex and a locked ProcessRunLock.
+/// The locks are private by design: to unlock them, destroy the
+/// CompleteExecutionContext.
+struct CompleteExecutionContext : ExecutionContext {
----------------
felipepiovezan wrote:

I had intended to ask for feedback on the name, but forgot to include it in the top level message; the suggestion is good IMO, so I'll update the PR.

One other thing that I want to do in a later PR -- in the same one where I clean all `if(process && target)` is add "get process" / "get target" methods that return references. Sadly I can't shadow the base class methods because they are called "GetProcessPtr/GetTargetPtr", so it would be awkward.

https://github.com/llvm/llvm-project/pull/152020