[Lldb-commits] [lldb] Reland "[NFC][lldb] Speed up lookup of shared modules" (229d860) (PR #152607)

[Augusto Noronha via lldb-commits]

================
@@ -755,6 +755,235 @@ size_t ModuleList::GetIndexForModule(const Module *module) const {
 }
 
 namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+  /// Finds all the modules matching the module_spec, and adds them to \p
+  /// matching_module_list.
+  void FindModules(const ModuleSpec &module_spec,
+                   ModuleList &matching_module_list) const {
----------------
augusto2112 wrote:

In general I prefer returning instead of out parameters, but in this case I'd prefer to keep it consistent with the signature of `ModuleList::FindModules`

https://github.com/llvm/llvm-project/pull/152607