[Lldb-commits] [lldb] [lldb][rpc] Add sysroot to lldb-rpc-gen test suite invocation (PR #151291)

[Chelsea Cassanova via lldb-commits]

chelcassanova wrote:

> Was this always happening before?

Yes, so we had to disable the tests downstream. Giving this patch another look though, I think this can be closed and we can run the tests for RPC without needing this extra infrastructure. There's 2 main reasons that we would need this sysroot:

1. Because we currently use non-built-in int types like `size_t` when we check for things like a pointer followed by a length, this requires an include like `cstddef`, but if we just use built-ins then we can avoid this.
2. Because we include SBDefines, as we define the test classes with the LLDB_API attribute (`class LLDB_API SBRPC_CheckConstCharPtrPtrWithLen`). I think we should be able to remove the attribute for the test classes alone to avoid the include of SBDefines.

https://github.com/llvm/llvm-project/pull/151291