[Lldb-commits] [lldb] [lldb-dap] Add readOnly attribute for variables (PR #151884)

[Walter Erquinigo via lldb-commits]

================
@@ -301,6 +301,14 @@ Variable CreateVariable(lldb::SBValue v, int64_t var_ref, bool format_hex,
   if (lldb::addr_t addr = v.GetLoadAddress(); addr != LLDB_INVALID_ADDRESS)
     var.memoryReference = addr;
 
+  bool is_readonly = v.GetType().IsAggregateType() ||
----------------
walter-erquinigo wrote:

This is not the right place for this check. Instead, add a method in the `SBType` class that does it. A possible name is `IsWritable`, and invoke it from here.

https://github.com/llvm/llvm-project/pull/151884