[Lldb-commits] [lldb] 0f08dc8 - [lldb] Use fully qualified name instead of namespace (NFC)

Jonas Devlieghere via lldb-commits lldb-commits at lists.llvm.org
Mon Aug 4 09:22:30 PDT 2025


Author: Jonas Devlieghere
Date: 2025-08-04T09:22:25-07:00
New Revision: 0f08dc84405796c25c070ef57258309f66017984

URL: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984
DIFF: https://github.com/llvm/llvm-project/commit/0f08dc84405796c25c070ef57258309f66017984.diff

LOG: [lldb] Use fully qualified name instead of namespace (NFC)

In #151761, both Alex and Pavel prefer to use a fully qualified name
instead of opening a namespace. This PR addresses that post-commit
feedback.

Added: 
    

Modified: 
    lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
index 42dc579206b44..b07415e899bf5 100644
--- a/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
+++ b/lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.cpp
@@ -1473,10 +1473,8 @@ python::runStringMultiLine(const llvm::Twine &string,
   return Take<PythonObject>(result);
 }
 
-namespace lldb_private {
-namespace python {
-PyObject *RunString(const char *str, int start, PyObject *globals,
-                    PyObject *locals) {
+PyObject *lldb_private::python::RunString(const char *str, int start,
+                                          PyObject *globals, PyObject *locals) {
   const char *filename = "<string>";
 
   // Compile the string into a code object.
@@ -1493,7 +1491,7 @@ PyObject *RunString(const char *str, int start, PyObject *globals,
   return result;
 }
 
-int RunSimpleString(const char *str) {
+int lldb_private::python::RunSimpleString(const char *str) {
   PyObject *main_module = PyImport_AddModule("__main__");
   if (!main_module)
     return -1;
@@ -1508,7 +1506,4 @@ int RunSimpleString(const char *str) {
 
   return 0;
 }
-} // namespace python
-} // namespace lldb_private
-
 #endif


        


More information about the lldb-commits mailing list