[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[Jonas Devlieghere via lldb-commits]

================
@@ -1284,6 +1285,54 @@ ObjectFileELF::RefineModuleDetailsFromNote(lldb_private::DataExtractor &data,
   return error;
 }
 
+void ObjectFileELF::ParseRISCVAttributes(DataExtractor &data, uint64_t length,
+                                         ArchSpec &arch_spec) {
+  lldb::offset_t Offset = 0;
+
+  uint8_t FormatVersion = data.GetU8(&Offset);
----------------
JDevlieghere wrote:

This function is mixing-and-matching LLVM and LLDB coding style. Please use the latter and be consistent with the surrounding code.
```suggestion
  uint8_t format_version = data.GetU8(&Offset);
```

https://github.com/llvm/llvm-project/pull/147990