[Lldb-commits] [lldb] [RISCV-LLDB] RISCV feature attribute support and allows overriding additional(default) feature (PR #147990)

[Jonas Devlieghere via lldb-commits]

================
@@ -537,6 +537,15 @@ class ArchSpec {
 
   void SetFlags(const std::string &elf_abi);
 
+  // Sets the target specific disassembly feature string
+  // for ELF disassembly.
+  void SetAdditionalDisassemblyFeatureStr(llvm::StringRef additional_features);
+
+  // Get the current target disassembly feature string.
+  llvm::StringRef GetAdditionalDisassemblyFeatureStr() const {
+    return llvm::StringRef(m_additional_disassembly_feature_str);
+  }
----------------
JDevlieghere wrote:

The comment isn't adding much value. I would also shorten this by dropping "additional" and "Str" from the function name. 
```suggestion
  llvm::StringRef GetDisassemblyFeatures() const {
    return m_disassembly_feature_str;
  }
```

https://github.com/llvm/llvm-project/pull/147990