[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

[Dave Lee via lldb-commits]

================
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
                                      expr);
       }
 
-      dump_val_object(*valobj_sp);
-      return;
+      bool failed = errorToBool(dump_val_object(*valobj_sp));
----------------
kastiglione wrote:

I thought about logging them, I'll add that.

> combine the errors with AppendError if the overall operation fails.

I worry it would be confusing to see multiple sets errors, since there's no guarantee that they are complimentary. I presume that the errors for expression evaluation would be enough. There's also the question of volume. Over a certain volume and people might think lldb is broken.

https://github.com/llvm/llvm-project/pull/151374