[Lldb-commits] [lldb] [lldb] add software watchpoints support (PR #151195)

[via lldb-commits]

dlav-sc wrote:

> I take from this that GDB also does not use extra remote protocol packets to implement this?

Yes

> GDB code breaks actually can have a condition list that's evaluated on the target side

LLDB supports conditions on watchpoints too and there's nothing special about software watchpoints in this regard. LLDB evaluates conditions on the target using the expression mechanism, so lldb-server doesn't even know about conditions of its watchpoints.

Originally, the condition checking logic was implemented in `StopInfo.cpp`. As part of refactoring `StopInfo.cpp`, I moved this logic to the `CheckWatchpointCondition` function in `Watchpoint.cpp` without modifying the logic itself.

https://github.com/llvm/llvm-project/pull/151195