[Lldb-commits] [lldb] [lldb][AArch64] Fix arm64 hardware breakpoint/watchpoint to arm32 process. (PR #147198)

[David Spickett via lldb-commits]

================
@@ -74,8 +75,10 @@ class NativeRegisterContextLinux_arm : public NativeRegisterContextLinux {
 
   bool WatchpointIsEnabled(uint32_t wp_index);
 
-  // Debug register type select
-  enum DREGType { eDREGTypeWATCH = 0, eDREGTypeBREAK };
+  using DREGType = NativeRegisterContextDBReg::DREGType;
+  static const DREGType eDREGTypeBREAK = DREGType::eDREGTypeBREAK;
+  static const DREGType eDREGTypeWATCH = DREGType::eDREGTypeWATCH;
+  using DREG = NativeRegisterContextDBReg::DREG;
----------------
DavidSpickett wrote:

I do have those changes still.

I suggest that we go ahead with your change here, as I don't want to derail you from the problem you came here to fix.

Once that's in, I will rebase my changes on top. I needed to read them through carefully anyway, so I can do both at the same time. I want to be sure I don't drop any Arm/Thumb handling details along the way.

https://github.com/llvm/llvm-project/pull/147198