[Lldb-commits] [lldb] [lldb] Add WebAssembly Process Plugin (PR #150143)

[David Spickett via lldb-commits]

================
@@ -0,0 +1,131 @@
+//===----------------------------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "ProcessWasm.h"
+#include "ThreadWasm.h"
+#include "lldb/Core/Module.h"
+#include "lldb/Core/PluginManager.h"
+#include "lldb/Core/Value.h"
+#include "lldb/Utility/DataBufferHeap.h"
+
+#include "lldb/Target/UnixSignals.h"
+
+using namespace lldb;
+using namespace lldb_private;
+using namespace lldb_private::process_gdb_remote;
+using namespace lldb_private::wasm;
+
+LLDB_PLUGIN_DEFINE(ProcessWasm)
+
+ProcessWasm::ProcessWasm(lldb::TargetSP target_sp, ListenerSP listener_sp)
+    : ProcessGDBRemote(target_sp, listener_sp) {
+  // Always use Linux signals for Wasm process.
+  m_unix_signals_sp = UnixSignals::Create(ArchSpec{"wasm32-unknown-wasi-wasm"});
----------------
DavidSpickett wrote:

Ok so signals are something that has to be built on that basic feature, thanks for letting us know.

I think I found why this triple is being used, it's the one that the debug stub in WAMR always reports - https://github.com/bytecodealliance/wasm-micro-runtime/blob/d298a66d38960719e17fbe27e8f529d6515bad26/core/iwasm/libraries/debug-engine/handler.c#L243.

So I'd be fine saying:
```
// WAMR always reports this triple.
```

https://github.com/llvm/llvm-project/pull/150143