[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

[Pavel Labath via lldb-commits]

================
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp ------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#include "lldb/Utility/Connection.h"
+#include "AdbClientUtils.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/Status.h"
+#include "lldb/Utility/Timeout.h"
+#include <chrono>
+#include <cstdlib>
+#include <sstream>
+
+using namespace lldb;
+using namespace lldb_private;
+using namespace lldb_private::platform_android;
+using namespace std::chrono;
+
----------------
labath wrote:

For better or worse, the prevailing style in llvm is to use "using namespace" in .cpp files instead of opening namespaces explicitly. However, this file uses a combination of the two, which is definitely not common or useful.

I'd suggest dropping the explicit namespaces and sticking to "using namespace" as that's the prevailing style. I'd also think you should drop the `adb_client_utils` namespace altogether. We don't put every file into a namespace of its own.

https://github.com/llvm/llvm-project/pull/145382