[Lldb-commits] [lldb] [lldb] Remove HasCallbackParameter (PR #150366)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>



---
Full diff: https://github.com/llvm/llvm-project/pull/150366.diff


2 Files Affected:

- (modified) lldb/tools/lldb-rpc-gen/RPCCommon.cpp (-14) 
- (modified) lldb/tools/lldb-rpc-gen/RPCCommon.h (-1) 


``````````diff
diff --git a/lldb/tools/lldb-rpc-gen/RPCCommon.cpp b/lldb/tools/lldb-rpc-gen/RPCCommon.cpp
index 6f0abe4b1ae87..7af6ee37f248b 100644
--- a/lldb/tools/lldb-rpc-gen/RPCCommon.cpp
+++ b/lldb/tools/lldb-rpc-gen/RPCCommon.cpp
@@ -308,20 +308,6 @@ bool lldb_rpc_gen::MethodIsDisallowed(ASTContext &Context,
   return isDisallowed;
 }
 
-bool lldb_rpc_gen::HasCallbackParameter(CXXMethodDecl *MDecl) {
-  bool HasCallbackParameter = false;
-  bool HasBatonParameter = false;
-  auto End = MDecl->parameters().end();
-  for (auto Iter = MDecl->parameters().begin(); Iter != End; Iter++) {
-    if ((*Iter)->getType()->isFunctionPointerType())
-      HasCallbackParameter = true;
-    else if ((*Iter)->getType()->isVoidPointerType())
-      HasBatonParameter = true;
-  }
-
-  return HasCallbackParameter && HasBatonParameter;
-}
-
 // NOTE: There's possibly a more clever way to do this, but we're keeping
 // the string replacement way here. Here is why it is written this way:
 // By the time we have already created a `Method` object, we have extracted the
diff --git a/lldb/tools/lldb-rpc-gen/RPCCommon.h b/lldb/tools/lldb-rpc-gen/RPCCommon.h
index edc03b4f81a3d..2a309d05e5ef7 100644
--- a/lldb/tools/lldb-rpc-gen/RPCCommon.h
+++ b/lldb/tools/lldb-rpc-gen/RPCCommon.h
@@ -32,7 +32,6 @@ bool TypeIsDisallowedClass(QualType T);
 bool TypeIsCallbackFunctionPointer(QualType T);
 
 bool MethodIsDisallowed(ASTContext &Context, CXXMethodDecl *MDecl);
-bool HasCallbackParameter(CXXMethodDecl *MDecl);
 
 std::string ReplaceLLDBNamespaceWithRPCNamespace(std::string Name);
 std::string StripLLDBNamespace(std::string Name);

``````````

</details>


https://github.com/llvm/llvm-project/pull/150366