[Lldb-commits] [lldb] [lldb] refactor PlatformAndroid (PR #145382)

[Su Shi via lldb-commits]

================
@@ -0,0 +1,162 @@
+//===-- AdbClientUtils.cpp ------------------------------------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+#include "lldb/Utility/Connection.h"
+#include "AdbClientUtils.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#include "lldb/Utility/Status.h"
+#include "lldb/Utility/Timeout.h"
+#include <chrono>
+#include <cstdlib>
+#include <sstream>
----------------
metacpp wrote:

May consider following Google C++ style on order of includes:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes


```suggestion
#include "AdbClientUtils.h"

#include <chrono>
#include <cstdlib>
#include <sstream>

#include "lldb/Utility/Connection.h"
#include "lldb/Utility/LLDBLog.h"
#include "lldb/Utility/Log.h"
#include "lldb/Utility/Status.h"
#include "lldb/Utility/Timeout.h"
```

https://github.com/llvm/llvm-project/pull/145382