[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

Sun Jul 20 11:00:35 PDT 2025

eronnen wrote:

> From the issue, we can have persistent assembly source breakpoint if it is set from the disassembly view.
> 
> We only create sourceReference and virtual disassembly file if there is no source file for that frame.
> 
> we can store the necessary information in the adapter data to recreate an instruction break-point and handle it like an instruction break-point.
> 
> Relevant Infographic.
> 
> <img alt="image" width="2000" height="1486" src="https://private-user-images.githubusercontent.com/57949090/466522246-ce8aec05-7a0e-4bec-bbd8-413d33424515.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NTI5NjUyMjQsIm5iZiI6MTc1Mjk2NDkyNCwicGF0aCI6Ii81Nzk0OTA5MC80NjY1MjIyNDYtY2U4YWVjMDUtN2EwZS00YmVjLWJiZDgtNDEzZDMzNDI0NTE1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwNzE5VDIyNDIwNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJmNGYzMDgxNzVhMWZlZWE0NWViOTNhYmQ4OGJkYzBmM2IwNjUyNjBhMGZkZDg1YjhhNDAxZWQ0NDY3NDllNWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.SH9cz48oDRbM8HTFULh3_SGX5ReZ6MeN7DGWlFuJ8oI">

Currently with this PR the persistent breakpoints will only work for breakpoints set from source view with assembly, meaning functions with missing symbols that are shown in assembly like this:

<img width="1520" height="1111" alt="Screenshot From 2025-07-20 19-59-40" src="https://github.com/user-attachments/assets/6cfd4b85-444a-4195-ae35-70f6b5cddce5" />

https://github.com/llvm/llvm-project/pull/148061