[Lldb-commits] [lldb] [LLDB] Fix Memory64 BaseRVA, move all non-stack memory to Mem64. (PR #146777)

[Jacob Lalonde via lldb-commits]

================
@@ -1130,9 +1122,9 @@ MinidumpFileBuilder::AddMemoryList_64(std::vector<CoreFileMemoryRange> &ranges,
   // Capture the starting offset for all the descriptors so we can clean them up
   // if needed.
   offset_t starting_offset =
-      GetCurrentDataEndOffset() + sizeof(llvm::support::ulittle64_t);
+      GetCurrentDataEndOffset() + sizeof(llvm::minidump::Memory64ListHeader);
----------------
Jlalond wrote:

I'm torn on this, as yes it can be checked in independently but I think without the testing changes it continues the trend of 'fixes with no tests'.

https://github.com/llvm/llvm-project/pull/146777