[Lldb-commits] [lldb] New DynamicLoaderDumpWithModuleList for coredump debugging (PR #149019)

[via lldb-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/source/Plugins/DynamicLoader/ModuleList-DYLD/DynamicLoaderDumpWithModuleList.cpp lldb/source/Plugins/DynamicLoader/ModuleList-DYLD/DynamicLoaderDumpWithModuleList.h lldb/include/lldb/Core/Debugger.h lldb/include/lldb/Core/LoadedModuleInfoList.h lldb/source/Core/Debugger.cpp lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp lldb/source/Plugins/Process/elf-core/ProcessElfCore.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Core/Debugger.cpp b/lldb/source/Core/Debugger.cpp
index c653a2caf..deb1c383e 100644
--- a/lldb/source/Core/Debugger.cpp
+++ b/lldb/source/Core/Debugger.cpp
@@ -295,7 +295,6 @@ bool Debugger::GetAutoConfirm() const {
       idx, g_debugger_properties[idx].default_uint_value != 0);
 }
 
-
 bool Debugger::GetUseModuleListDyld() const {
   const uint32_t idx = ePropertyUseModuleListDyld;
   return GetPropertyAtIndexAs<bool>(
diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
index a0402dde5..c3bc177fe 100644
--- a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
+++ b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -319,7 +319,7 @@ ProcessElfCore::GetLoadedModuleList() {
     std::unordered_map<std::string, std::pair<lldb::addr_t, lldb::addr_t>>
         module_range_map;
     for (const NT_FILE_Entry &file_entry : m_nt_file_entries) {
-      const std::string& module_path = file_entry.path;
+      const std::string &module_path = file_entry.path;
       auto module_iter = module_range_map.find(module_path);
       if (module_iter == module_range_map.end() ||
           module_iter->second.first > file_entry.start)

``````````

</details>


https://github.com/llvm/llvm-project/pull/149019