[Lldb-commits] [lldb] [lldb] Fix plugin test to not rely on enabled targets (PR #148956)

[via lldb-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-lldb

Author: David Peixotto (dmpots)

<details>
<summary>Changes</summary>

The plugins completion test was checking completions for the abi plugins. But the available abi plugins will depend on which [targets](https://github.com/llvm/llvm-project/blob/42d2ae1034b287eb60563c370dbf52c59b66db20/lldb/source/Plugins/ABI/CMakeLists.txt#L7) are enabled in the cmake build configuration.

This PR updates the test to check for the json object file instead which should be enabled on all builds.

---
Full diff: https://github.com/llvm/llvm-project/pull/148956.diff


1 Files Affected:

- (modified) lldb/test/API/commands/plugin/TestPlugin.py (+4-4) 


``````````diff
diff --git a/lldb/test/API/commands/plugin/TestPlugin.py b/lldb/test/API/commands/plugin/TestPlugin.py
index e7de7a3f797f1..bd8ab9604538e 100644
--- a/lldb/test/API/commands/plugin/TestPlugin.py
+++ b/lldb/test/API/commands/plugin/TestPlugin.py
@@ -82,10 +82,10 @@ def test_completions(self):
         )
 
         # A completion for a full namespace should contain the plugins in that namespace.
-        self.completions_contain("plugin list abi", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.s", ["abi.sysv-x86_64"])
-        self.completions_contain("plugin list abi.sysv-x", ["abi.sysv-x86_64"])
+        self.completions_contain("plugin list object-file", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.J", ["object-file.JSON"])
+        self.completions_contain("plugin list object-file.JS", ["object-file.JSON"])
 
         # Check for a completion that is a both a complete namespace and a prefix of
         # another namespace. It should return the completions for the plugins in the completed

``````````

</details>


https://github.com/llvm/llvm-project/pull/148956