[Lldb-commits] [lldb] [lldb] Fix race condition in Process::WaitForProcessToStop() (PR #144919)

[LLVM Continuous Integration via lldb-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/21064

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (test) failure: build (failure)
...
PASS: lldb-api :: commands/disassemble/basic/TestFrameDisassemble.py (30 of 2287)
UNSUPPORTED: lldb-api :: commands/dwim-print/objc/TestDWIMPrintObjC.py (31 of 2287)
PASS: lldb-api :: commands/expression/calculator_mode/TestCalculatorMode.py (32 of 2287)
PASS: lldb-api :: commands/expression/anonymous-struct/TestCallUserAnonTypedef.py (33 of 2287)
PASS: lldb-api :: commands/expression/argument_passing_restrictions/TestArgumentPassingRestrictions.py (34 of 2287)
PASS: lldb-api :: commands/expression/bitfield_enums/TestBitfieldEnums.py (35 of 2287)
PASS: lldb-api :: api/listeners/TestListener.py (36 of 2287)
PASS: lldb-api :: commands/expression/call-function/TestCallBuiltinFunction.py (37 of 2287)
UNSUPPORTED: lldb-api :: commands/expression/call-throws/TestCallThatThrows.py (38 of 2287)
PASS: lldb-api :: commands/command/script/TestCommandScript.py (39 of 2287)
FAIL: lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py (40 of 2287)
******************** TEST 'lldb-api :: commands/expression/call-restarts/TestCallThatRestarts.py' FAILED ********************
Script:
--
/usr/bin/python3.10 /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/dotest.py -u CXXFLAGS -u CFLAGS --env LLVM_LIBS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --env LLVM_INCLUDE_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/include --env LLVM_TOOLS_DIR=/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --arch aarch64 --build-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex --lldb-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-lldb/lldb-api --clang-module-cache-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/lldb-test-build.noindex/module-cache-clang/lldb-api --executable /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/lldb --compiler /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/clang --dsymutil /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin/dsymutil --make /usr/bin/gmake --llvm-tools-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./bin --lldb-obj-root /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/tools/lldb --lldb-libs-dir /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/./lib --cmake-build-type Release /home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/commands/expression/call-restarts -p TestCallThatRestarts.py
--
Exit Code: 1

Command Output (stdout):
--
lldb version 22.0.0git (https://github.com/llvm/llvm-project.git revision 8612926c306c5191a5fb385dd11467728c59e982)
  clang revision 8612926c306c5191a5fb385dd11467728c59e982
  llvm revision 8612926c306c5191a5fb385dd11467728c59e982
Skipping the following test categories: ['libc++', 'msvcstl', 'dsym', 'gmodules', 'debugserver', 'objc']

--
Command Output (stderr):
--
FAIL: LLDB (/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang-aarch64) :: test (TestCallThatRestarts.ExprCommandThatRestartsTestCase)
======================================================================
FAIL: test (TestCallThatRestarts.ExprCommandThatRestartsTestCase)
   Test calling function that hits a signal and restarts.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 581, in wrapper
    func(*args, **kwargs)
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 581, in wrapper
    func(*args, **kwargs)
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py", line 29, in test
    self.call_function()
  File "/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/llvm-project/lldb/test/API/commands/expression/call-restarts/TestCallThatRestarts.py", line 136, in call_function
    self.assertEqual(
AssertionError: 281473636542668 != 187650944797248 : Continuing returned to the place we started.
Config=aarch64-/home/tcwg-buildbot/worker/lldb-aarch64-ubuntu/build/bin/clang
----------------------------------------------------------------------
Ran 1 test in 0.595s

FAILED (failures=1)


```

</details>

https://github.com/llvm/llvm-project/pull/144919