[Lldb-commits] [lldb] [lldb][framework] Glob headers from source for framework (PR #148736)

[Chelsea Cassanova via lldb-commits]

================
@@ -106,17 +112,17 @@ add_dependencies(liblldb-resource-headers liblldb-header-staging)
 add_dependencies(liblldb liblldb-resource-headers)
 
 # Take the headers from the staging directory and fix up their includes for the framework.
-# Then write them to the output directory.
+# Then write them to the framework itself.
 # Also, run unifdef to remove any specified guards from the header files.
-file(GLOB lldb_framework_header_staging_list ${lldb_framework_header_staging}/*)
+file(GLOB lldb_framework_staged_headers ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders/*.h)
----------------
chelcassanova wrote:

> Do we need this at all? The framework-header-fix script is already doin the unifdefing so I'm not sure what this is doing in the first place.

If by this you mean `FrameworkHeaders` then I would say that I like having a staging directory to work from for the framework headers specifically, though I do agree that since the framework fix script already unifdefs the headers then the unifdefing that we have before we run the script should not be necessary anymore. I think from there then that loop that we have for unifdefing can be used for step (2) as you described while the loop for fixing up can be used for step (3). Any thoughts?

https://github.com/llvm/llvm-project/pull/148736