[Lldb-commits] [lldb] [lldb-dap] Re-land refactor of DebugCommunication. (PR #147787)

Ebuka Ezike via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 15 05:50:22 PDT 2025


================
@@ -1141,15 +1253,22 @@ def request_completions(self, text, frameId=None):
             "type": "request",
             "arguments": args_dict,
         }
-        return self.send_recv(command_dict)
-
-    def request_modules(self, startModule: int, moduleCount: int):
-        return self.send_recv(
-            {
-                "command": "modules",
-                "type": "request",
-                "arguments": {"startModule": startModule, "moduleCount": moduleCount},
-            }
+        return self._send_recv(command_dict)
+
+    def request_modules(
+        self,
+        start_module: Optional[int] = None,
+        module_count: Optional[int] = None,
+    ):
+        args_dict = {}
+
+        if start_module:
----------------
da-viper wrote:

```suggestion
        if start_module is not None:
```

https://github.com/llvm/llvm-project/pull/147787


More information about the lldb-commits mailing list