[Lldb-commits] [lldb] [lldb-dap] persistent assembly breakpoints (PR #148061)

[Pavel Labath via lldb-commits]

================
@@ -737,6 +738,11 @@ class LLDB_API SBTarget {
 
   lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address);
 
+  lldb::SBBreakpoint
+  BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr,
+                                addr_t offset = 0,
+                                addr_t instructions_offset = 0);
----------------
labath wrote:

We can add new APIs for lldb-dap, but they should make sense on their own. Right now, what kind of idea what kind of breakpoint this would set. Is the FileSpec the name of the module you're setting the breakpoint in? And does file_addr identify a file in that module? 

https://github.com/llvm/llvm-project/pull/148061