[Lldb-commits] [lldb] [LLDB] Add formatters for MSVC STL std::shared_ptr (PR #147575)

[via lldb-commits]

================
@@ -16,7 +16,7 @@ lldb::ValueObjectSP lldb_private::formatters::GetDesugaredSmartPointerValue(
 
   auto arg = container_type.GetTypeTemplateArgument(0);
   if (!arg)
-    return nullptr;
+    return ptr.GetSP(); // FIXME: PDB doesn't have info about template arguments
----------------
Nerixyz wrote:

> Can you confirm what configuration the bots are running though?

The API tests always run with DWARF: [Makefile.rules](https://github.com/llvm/llvm-project/blob/2d030b0ecdb32b7b6b9d47f66182db7e2dafa026/lldb/packages/Python/lldbsuite/test/make/Makefile.rules#L242-L246). That's why it's a bit more complicated to add a PDB setting there - some tests would break with PDB.

> Are we testing DWARF _and_ PDB somewhere?

Not in API tests. The shell tests do use PDB (when passing `--compiler=clang-cl`), because [`/Z7` is passed in `build.py`](https://github.com/llvm/llvm-project/blob/18ea6fcb23ff77362008a8e1ae8671d5d6f019fe/lldb/test/Shell/helper/build.py#L679). [`msstl_smoke.cpp`](https://github.com/llvm/llvm-project/blob/18ea6fcb23ff77362008a8e1ae8671d5d6f019fe/lldb/test/Shell/Process/Windows/msstl_smoke.cpp#L5) does this, for example.

https://github.com/llvm/llvm-project/pull/147575