[Lldb-commits] [lldb] [lldb] Improving synchronization of MainLoopWindows. (PR #147438)

via lldb-commits lldb-commits at lists.llvm.org
Tue Jul 8 09:04:22 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Host/windows/MainLoopWindows.cpp lldb/unittests/Host/MainLoopTest.cpp
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Host/windows/MainLoopWindows.cpp b/lldb/source/Host/windows/MainLoopWindows.cpp
index ae3d460aa..a1de895c0 100644
--- a/lldb/source/Host/windows/MainLoopWindows.cpp
+++ b/lldb/source/Host/windows/MainLoopWindows.cpp
@@ -67,7 +67,8 @@ public:
 
   void WillPoll() override {
     if (WaitForSingleObject(m_event, /*dwMilliseconds=*/0) != WAIT_TIMEOUT) {
-      // The thread has already signalled that the data is available. No need for further polling until we consume that event.
+      // The thread has already signalled that the data is available. No need
+      // for further polling until we consume that event.
       return;
     }
     if (WaitForSingleObject(m_ready, /*dwMilliseconds=*/0) != WAIT_TIMEOUT) {
@@ -122,7 +123,8 @@ public:
         continue;
       }
 
-      // Notify that data is available on the pipe. It's important to set this before clearing m_ready to avoid a race with WillPoll.
+      // Notify that data is available on the pipe. It's important to set this
+      // before clearing m_ready to avoid a race with WillPoll.
       SetEvent(m_event);
       // Stop polling until we're told to resume.
       ResetEvent(m_ready);

``````````

</details>


https://github.com/llvm/llvm-project/pull/147438


More information about the lldb-commits mailing list