[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

[John Harrison via lldb-commits]

================
@@ -236,6 +236,7 @@ contain the following key/value pairs:
 | **env**                           | dictionary  |     | Environment variables to set when launching the program. The format of each environment variable string is "VAR=VALUE" for environment variables with values or just "VAR" for environment variables with no values.
 | **stopOnEntry**                   | boolean     |     | Whether to stop program immediately after launching.
 | **runInTerminal**                 | boolean     |     | Launch the program inside an integrated terminal in the IDE. Useful for debugging interactive command line programs.
+| **runInTerminal**                 | string      |     | Specifies where program should be launch: `integrated` for an integrated terminal in the IDE, `external` for external terminal window or `console` (default) for IDE debug console.
----------------
ashgti wrote:

Also, https://code.visualstudio.com/docs/debugtest/debugging-configuration#_launchjson-attributes mentions in the common variables section the `console` key as well.

Its not strictly required, but it does match the behavior of other DAP implementations.

https://github.com/llvm/llvm-project/pull/146950