[Lldb-commits] [lldb] [lldb-dap] Use protocol types for modules request and events. (PR #146966)

[John Harrison via lldb-commits]

================
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &, DisassembledInstruction &,
               llvm::json::Path);
 llvm::json::Value toJSON(const DisassembledInstruction &);
 
+struct Module {
+  /// Unique identifier for the module.
+  std::string id;
+
+  /// A name of the module.
+  std::string name;
+
+  /// Logical full path to the module. The exact definition is implementation
+  /// defined, but usually this would be a full path to the on-disk file for the
+  /// module.
+  std::string path;
+
+  /// True if the module is optimized.
+  std::optional<bool> isOptimized;
----------------
ashgti wrote:

I don't think there is a meaningful distinct between `null` and `false` here, can this be `bool isOptional = false;` and only add it to the `toJSON` if its `true`?

https://github.com/llvm/llvm-project/pull/146966