[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

[Ebuka Ezike via lldb-commits]

================
@@ -447,7 +447,7 @@ llvm::json::Value CreateCompileUnit(lldb::SBCompileUnit &unit);
 llvm::json::Object CreateRunInTerminalReverseRequest(
     llvm::StringRef program, const std::vector<std::string> &args,
     const llvm::StringMap<std::string> &env, llvm::StringRef cwd,
-    llvm::StringRef comm_file, lldb::pid_t debugger_pid);
+    llvm::StringRef comm_file, lldb::pid_t debugger_pid, bool external);
----------------
da-viper wrote:

missing doc comment at the top. 

https://github.com/llvm/llvm-project/pull/146950