[Lldb-commits] [lldb] [lldb-dap] Add external terminal support (PR #146950)

[Ebuka Ezike via lldb-commits]

================
@@ -192,7 +193,7 @@ llvm::Error BaseRequestHandler::LaunchProcess(
     // about process state changes during the launch.
     ScopeSyncMode scope_sync_mode(dap.debugger);
 
-    if (arguments.runInTerminal) {
+    if (arguments.terminal) {
----------------
da-viper wrote:

```suggestion
    if (arguments.terminal != Protocol::eConsole) {
```

https://github.com/llvm/llvm-project/pull/146950