[Lldb-commits] [lldb] [lldb][test] Combine libstdc++ and libc++ std::shared_ptr tests into generic test (PR #147141)

[Michael Buch via lldb-commits]

Michael137 wrote:

> There are two failures:
> 
>     * the libc++ pointer child is called `__ptr_`, not `pointer`. I think we should clone/rename the child so that the child has a consistent name. This could be particularly useful for writing other data formatters, which may want to dereference a shared_ptr without caring which stdlib implementation they are using.
> 
>     * the libstdc++ child type is `std::goo<...>::type` instead of `int` in libc++. I think the libc++ implementation is better. The case for unification is slightly weaker here (people can always resolve the typedef manually), though I'd still do it if its easy enough.

Yup spot on! I addressed these in https://github.com/llvm/llvm-project/pull/147166 and https://github.com/llvm/llvm-project/pull/147165

https://github.com/llvm/llvm-project/pull/147141