[Lldb-commits] [lldb] [lldb][Formatter] Consolidate libstdc++ and libc++ unique_ptr formatter tests into generic test (PR #147031)
Pavel Labath via lldb-commits
lldb-commits at lists.llvm.org
Fri Jul 4 03:28:32 PDT 2025
https://github.com/labath commented:
Looks good modulo the failure in the libstdc++ version. The type name comes out different, presumably because libstdc++ doesn't contain the magic to print the template as std::string.
Testing string name printing is not really relevant for the unique_ptr formatter, so I'd delete the check from there. Testing that `SomeTemplate<std::string>` prints the right way is useful, but would be better of in the test for preferred name printing (if we don't do that already).
https://github.com/llvm/llvm-project/pull/147031
More information about the lldb-commits
mailing list