[Lldb-commits] [lldb] [LLDB] Fix Incorrect offset for Memory64 RVA in Minidump (+ Testing changes) (PR #146777)

[Pavel Labath via lldb-commits]

labath wrote:

> This removes the need to pass flags (which is not a design decision I like but I didn't see many alternatives). @labath any opposition to putting everything in mem64?

I don't have an opinion on that. I'm not currently involved in minidumps.

What I am not excited about is the idea of creating stringly-typed forever stable API for the purpose of testing a fix like this. As for alternatives, an "obvious" one is a unit tests. If you manage (I think it should be possible) instantiate the minidump writer with a mock process, then you can call any API you want, such as one that writes a 64-bit region (but still pass it a small memory block).

https://github.com/llvm/llvm-project/pull/146777