[Lldb-commits] [lldb] [LLDB] Optimize identifier lookup in DIL (PR #146094)

[Michael Buch via lldb-commits]

Michael137 wrote:

Looks like this is failing on macOS CI: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/28857/execution/node/106/log/?consoleFull
```
14:41:07  FAIL: test_frame_var (TestFrameVarDILGlobalVariableLookup.TestFrameVarDILGlobalVariableLookup)
14:41:07  ----------------------------------------------------------------------
14:41:07  Traceback (most recent call last):
14:41:07    File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/test/API/commands/frame/var-dil/basics/GlobalVariableLookup/TestFrameVarDILGlobalVariableLookup.py", line 47, in test_frame_var
14:41:07      self.expect_var_path("ExtStruct::static_inline", value="16")
14:41:07    File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2589, in expect_var_path
14:41:07      value_check.check_value(self, eval_result, str(eval_result))
14:41:07    File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 301, in check_value
14:41:07      test_base.assertSuccess(val.GetError())
14:41:07    File "/Users/ec2-user/jenkins/workspace/llvm.org/as-lldb-cmake/llvm-project/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 2597, in assertSuccess
14:41:07      self.fail(self._formatMessage(msg, "'{}' is not success".format(error)))
14:41:07  AssertionError: '<user expression 0>:1:1: use of undeclared identifier 'ExtStruct::static_inline'
14:41:07     1 | ExtStruct::static_inline
14:41:07       | ^' is not success
```

Could you take a look? And revert if the fix might need some time to land?

This might be isolated to dsyms (i remember dsymutil stripping some static inlines, but i forget exactly in which cases).

https://github.com/llvm/llvm-project/pull/146094