[Lldb-commits] [lldb] [lldb] Use correct size when dumping DWARF64 DW_FORM_ref_addr (PR #146686)

Hemang Gadhavi via lldb-commits lldb-commits at lists.llvm.org
Thu Jul 3 02:22:00 PDT 2025


================
@@ -416,12 +416,8 @@ void DWARFFormValue::Dump(Stream &s) const {
   case DW_FORM_ref_addr: {
     assert(m_unit); // Unit must be valid for DW_FORM_ref_addr objects or we
                     // will get this wrong
-    if (m_unit->GetVersion() <= 2)
-      DumpAddress(s.AsRawOstream(), uvalue, sizeof(uint64_t) * 2);
-    else
-      DumpAddress(s.AsRawOstream(), uvalue,
-                  4 * 2); // 4 for DWARF32, 8 for DWARF64, but we don't
----------------
HemangGadhavi wrote:

Just wondering, why it was "* by 2"? so for DWARF32 also its returning 8 ? 
with current changes it will return 4 or 8 based on format.

https://github.com/llvm/llvm-project/pull/146686


More information about the lldb-commits mailing list