[Lldb-commits] [lldb] [lldb][test] Turn (most) libcxx data-formatters tests into generic tests (PR #146740)
via lldb-commits
lldb-commits at lists.llvm.org
Wed Jul 2 09:19:21 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ranges/ref_view/TestDataFormatterStdRangesRefView.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/atomic/TestDataFormatterStdAtomic.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/chrono/TestDataFormatterStdChrono.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/function/TestDataFormatterStdFunction.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/initializerlist/TestDataFormatterStdInitializerList.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/iterator/TestDataFormatterIterator.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/map/TestDataFormatterMap.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/queue/TestDataFormatterStdQueue.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/shared_ptr/TestDataFormatterStdSharedPtr.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/span/TestDataFormatterStdSpan.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/string_view/TestDataFormatterStdStringView.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/tuple/TestDataFormatterTuple.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unique_ptr/TestDataFormatterUniquePtr.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/unordered_map-iterator/TestDataFormatterStdUnorderedMapIterator.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/valarray/TestDataFormatterStdValarray.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/variant/TestDataFormatterStdVariant.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vbool/TestDataFormatterVBool.py lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/vector/TestDataFormatterVector.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- atomic/TestDataFormatterStdAtomic.py 2025-07-02 16:15:56.000000 +0000
+++ atomic/TestDataFormatterStdAtomic.py 2025-07-02 16:18:53.181837 +0000
@@ -65,12 +65,12 @@
"frame var p.child.parent", substrs=["p.child.parent = {\n Value = 0x"]
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- chrono/TestDataFormatterStdChrono.py 2025-07-02 16:15:56.000000 +0000
+++ chrono/TestDataFormatterStdChrono.py 2025-07-02 16:18:53.306122 +0000
@@ -432,12 +432,12 @@
],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- function/TestDataFormatterStdFunction.py 2025-07-02 16:15:56.000000 +0000
+++ function/TestDataFormatterStdFunction.py 2025-07-02 16:18:53.335679 +0000
@@ -81,12 +81,12 @@
"frame variable f5", substrs=["f5 = Function = Bar::add_num(int) const"]
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- initializerlist/TestDataFormatterStdInitializerList.py 2025-07-02 16:15:56.000000 +0000
+++ initializerlist/TestDataFormatterStdInitializerList.py 2025-07-02 16:18:53.353665 +0000
@@ -38,12 +38,12 @@
substrs=['[4] = "surprise it is a long string!! yay!!"'],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- iterator/TestDataFormatterIterator.py 2025-07-02 16:15:56.000000 +0000
+++ iterator/TestDataFormatterIterator.py 2025-07-02 16:18:53.390686 +0000
@@ -83,12 +83,12 @@
self.expect("frame variable siumI.second", substrs=["second = 137"])
self.expect("frame variable siumI.second", substrs=["first"], matching=False)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- map/TestDataFormatterMap.py 2025-07-02 16:15:56.000000 +0000
+++ map/TestDataFormatterMap.py 2025-07-02 16:18:53.462233 +0000
@@ -325,12 +325,12 @@
self.expect("frame variable ss", substrs=["%s::map" % ns, "size=0", "{}"])
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- queue/TestDataFormatterStdQueue.py 2025-07-02 16:15:56.000000 +0000
+++ queue/TestDataFormatterStdQueue.py 2025-07-02 16:18:53.484280 +0000
@@ -38,12 +38,12 @@
self.check_variable("q1")
self.check_variable("q2")
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py 2025-07-02 16:15:56.000000 +0000
+++ ranges/ref_view/TestDataFormatterLibcxxRangesRefView.py 2025-07-02 16:18:53.517141 +0000
@@ -68,12 +68,12 @@
],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcpp(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- ranges/ref_view/TestDataFormatterStdRangesRefView.py 2025-07-02 16:15:56.000000 +0000
+++ ranges/ref_view/TestDataFormatterStdRangesRefView.py 2025-07-02 16:18:53.546190 +0000
@@ -68,12 +68,12 @@
],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcpp(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- shared_ptr/TestDataFormatterStdSharedPtr.py 2025-07-02 16:15:56.000000 +0000
+++ shared_ptr/TestDataFormatterStdSharedPtr.py 2025-07-02 16:18:53.614160 +0000
@@ -94,12 +94,12 @@
self.expect_var_path("(*ptr_node).value", value="1")
self.expect_var_path("(*(*ptr_node).next).value", value="2")
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- span/TestDataFormatterStdSpan.py 2025-07-02 16:15:56.000000 +0000
+++ span/TestDataFormatterStdSpan.py 2025-07-02 16:18:53.669932 +0000
@@ -156,17 +156,17 @@
self.check_size("nested", 2)
@add_test_categories(["libc++"])
@skipIf(compiler="clang", compiler_version=["<", "11.0"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
@skipIf(compiler="clang", compiler_version=["<", "11.0"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
def do_test_ref_and_ptr(self):
"""Test that std::span is correctly formatted when passed by ref and ptr"""
(self.target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
@@ -181,13 +181,13 @@
self.expect("frame variable ptr", patterns=["ptr = 0x[0-9a-f]+ size=5"])
@add_test_categories(["libc++"])
@skipIf(compiler="clang", compiler_version=["<", "11.0"])
def test_ref_and_ptr_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test_ref_and_ptr()
@add_test_categories(["libstdcxx"])
@skipIf(compiler="clang", compiler_version=["<", "11.0"])
def test_ref_and_ptr_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test_ref_and_ptr()
--- string_view/TestDataFormatterStdStringView.py 2025-07-02 16:15:56.000000 +0000
+++ string_view/TestDataFormatterStdStringView.py 2025-07-02 16:18:53.740086 +0000
@@ -158,15 +158,15 @@
@expectedFailureAll(
bugnumber="llvm.org/pr36109", debug_info="gmodules", triple=".*-android"
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@expectedFailureAll(
bugnumber="llvm.org/pr36109", debug_info="gmodules", triple=".*-android"
)
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- tuple/TestDataFormatterTuple.py 2025-07-02 16:15:56.000000 +0000
+++ tuple/TestDataFormatterTuple.py 2025-07-02 16:18:53.761119 +0000
@@ -42,12 +42,12 @@
],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
-
+
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- unique_ptr/TestDataFormatterUniquePtr.py 2025-07-02 16:15:56.000000 +0000
+++ unique_ptr/TestDataFormatterUniquePtr.py 2025-07-02 16:18:53.805472 +0000
@@ -119,12 +119,12 @@
self.expect_var_path("(*ptr_node).value", value="1")
self.expect_var_path("(*(*ptr_node).next).value", value="2")
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- unordered_map-iterator/TestDataFormatterStdUnorderedMapIterator.py 2025-07-02 16:15:56.000000 +0000
+++ unordered_map-iterator/TestDataFormatterStdUnorderedMapIterator.py 2025-07-02 16:18:53.842822 +0000
@@ -112,12 +112,12 @@
self.check_ptr_ptr("ptr5")
self.check_ptr_ptr("ptr6")
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- valarray/TestDataFormatterStdValarray.py 2025-07-02 16:15:56.000000 +0000
+++ valarray/TestDataFormatterStdValarray.py 2025-07-02 16:18:53.889320 +0000
@@ -178,12 +178,12 @@
substrs=['array index 3 is not valid for "(indirect_array<int>) ia"'],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- variant/TestDataFormatterStdVariant.py 2025-07-02 16:15:56.000000 +0000
+++ variant/TestDataFormatterStdVariant.py 2025-07-02 16:18:53.918402 +0000
@@ -85,12 +85,12 @@
substrs=["v_300_types_no_value = No Value"],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- vbool/TestDataFormatterVBool.py 2025-07-02 16:15:56.000000 +0000
+++ vbool/TestDataFormatterVBool.py 2025-07-02 16:18:53.942385 +0000
@@ -73,12 +73,12 @@
],
)
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
--- vector/TestDataFormatterVector.py 2025-07-02 16:15:56.000000 +0000
+++ vector/TestDataFormatterVector.py 2025-07-02 16:18:53.995555 +0000
@@ -168,16 +168,16 @@
self.expect("frame variable strings", substrs=["vector has 0 items"])
@add_test_categories(["libc++"])
def test_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test()
@add_test_categories(["libstdcxx"])
def test_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test()
def do_test_ref_and_ptr(self):
"""Test that that file and class static variables display correctly."""
(self.target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(
@@ -193,12 +193,12 @@
self.expect("expression ptr", substrs=["$", "size=7"])
@add_test_categories(["libc++"])
def test_ref_and_ptr_libcxx(self):
- self.build(dictionary={"USE_LIBCPP" : 1})
+ self.build(dictionary={"USE_LIBCPP": 1})
self.do_test_ref_and_ptr()
@add_test_categories(["libstdcxx"])
def test_ref_and_ptr_libstdcxx(self):
- self.build(dictionary={"USE_LIBSTDCPP" : 1})
+ self.build(dictionary={"USE_LIBSTDCPP": 1})
self.do_test_ref_and_ptr()
``````````
</details>
https://github.com/llvm/llvm-project/pull/146740
More information about the lldb-commits
mailing list