[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

[Pavel Labath via lldb-commits]

================
@@ -124,7 +124,9 @@ TEST_F(MainLoopTest, NoSpuriousPipeReads) {
           // pipe is empty, and we should not be called anymore.
           char X;
           size_t len = sizeof(X);
-          EXPECT_THAT_EXPECTED(r->Read(&X, len).ToError(), llvm::HasValue(1));
+          ASSERT_THAT_ERROR(r->Read(&X, len).ToError(), llvm::Succeeded());
+          EXPECT_EQ(len, sizeof(X));
+          EXPECT_EQ(X, 'X');
----------------
labath wrote:

My bad. I was looking at the interface for the pipe class. We really  ought to rectify the two :/

https://github.com/llvm/llvm-project/pull/145621