[Lldb-commits] [lldb] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

[Hemang Gadhavi via lldb-commits]

HemangGadhavi wrote:

@labath @DavidSpickett @JDevlieghere @Michael137 
Thanks everyone for the valuable feedback. 

I have addressed all the review comments please verify once again. 

> We should do something similar. We already have the FormParams object accessible from inside our DWARFUnit (through the m_header field), so I think it'd be best to replace `GetFormat` method you added with `GetFormParams`, and then the parsing code would do a `m_unit->GetFormParams().getDwarfOffsetByteSize`

@labath I have added the `GetFormParams()` and remove `if dwarf64()`.

On the Testing front, I have created the unit test case for `DWARF64` format, which basically testing the `.debug_info` header(including `DWARF64` format, address size) and the Compilation Unit header, 
Also its testing the `DWARF64` related attributes which are included in this PR (i.e. DW_FORM_sec_offset & DW_FORM_strp).

Please review once and give your feedback, also let me know is there any additional testing required for the same ?

Please Note that, clang-format is failling but not because of this PR changes but because of some existing format. 

https://github.com/llvm/llvm-project/pull/145645