[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

[David Spickett via lldb-commits]

================
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
     configuration.libcxx_library_dir = args.libcxx_library_dir
     configuration.cmake_build_type = args.cmake_build_type.lower()
 
+    configuration.target_triple = args.target_triple
+
----------------
DavidSpickett wrote:

Also I'm bothered that there isn't any explicit enabling of the MSVC STL in the compiler flags, but I suppose that's what you and Pavel have been debating this whole time :)

What you've got is a predicate that says "does this compiler by default use MSVC STL" then the tests deliberately don't add any stlib related flags, so that they get that default. And as you mentioned above, there is no "opt in" to MSVC STL anyway.

Do I understand correctly? If so I think that is a reasonable way to do this. The fact that it relies on implicit selection seems to be out of your control.

https://github.com/llvm/llvm-project/pull/143177