[Lldb-commits] [lldb] [lldb] Adding file and pipe support to lldb_private::MainLoopWindows. (PR #145621)

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 27 02:07:00 PDT 2025


================
@@ -21,7 +24,9 @@
 using namespace lldb;
 using namespace lldb_private;
 
-static DWORD ToTimeout(std::optional<MainLoopWindows::TimePoint> point) {
+namespace {
----------------
labath wrote:

according to the [coding standards](https://llvm.org/docs/CodingStandards.html#restrict-visibility) anonymous namespaces should be as small as possible. That means the function should stay static and (large) methods should be defined out of line (and out of the namespace)

https://github.com/llvm/llvm-project/pull/145621


More information about the lldb-commits mailing list