[Lldb-commits] [lldb] Fix a bug in the breakpoint ID verifier in CommandObjectBreakpoint. (PR #145994)
via lldb-commits
lldb-commits at lists.llvm.org
Thu Jun 26 16:46:34 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {darker}-->
:warning: Python code formatter, darker found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
darker --check --diff -r HEAD~1...HEAD lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py
``````````
</details>
<details>
<summary>
View the diff from darker here.
</summary>
``````````diff
--- TestLocationsAfterRebuild.py 2025-06-26 23:35:12.000000 +0000
+++ TestLocationsAfterRebuild.py 2025-06-26 23:46:10.688897 +0000
@@ -7,48 +7,50 @@
import lldb
import lldbsuite.test.lldbutil as lldbutil
from lldbsuite.test.lldbtest import *
import os
+
class TestLocationsAfterRebuild(TestBase):
# If your test case doesn't stress debug info, then
# set this to true. That way it won't be run once for
# each debug info format.
NO_DEBUG_INFO_TESTCASE = True
def test_remaining_location_spec(self):
"""If we rebuild a couple of times some of the old locations
- get removed. Make sure the command-line breakpoint id
- validator still works correctly."""
- self.build(dictionary={"C_SOURCES" : "main.c", "EXE" : "a.out"})
+ get removed. Make sure the command-line breakpoint id
+ validator still works correctly."""
+ self.build(dictionary={"C_SOURCES": "main.c", "EXE": "a.out"})
path_to_exe = self.getBuildArtifact()
-
- (target, process, thread, bkpt) = lldbutil.run_to_name_breakpoint(
- self, "main"
- )
+
+ (target, process, thread, bkpt) = lldbutil.run_to_name_breakpoint(self, "main")
# Let the process continue to exit:
process.Continue()
self.assertEqual(process.GetState(), lldb.eStateExited, "Ran to completion")
os.remove(path_to_exe)
# We have to rebuild twice with changed sources to get
# us to remove the first set of locations:
- self.build(dictionary={"C_SOURCES" : "second_main.c", "EXE" : "a.out"})
+ self.build(dictionary={"C_SOURCES": "second_main.c", "EXE": "a.out"})
- (target, process, thread, bkpt) = lldbutil.run_to_breakpoint_do_run(self, target, bkpt)
-
+ (target, process, thread, bkpt) = lldbutil.run_to_breakpoint_do_run(
+ self, target, bkpt
+ )
+
# Let the process continue to exit:
process.Continue()
self.assertEqual(process.GetState(), lldb.eStateExited, "Ran to completion")
os.remove(path_to_exe)
- self.build(dictionary={"C_SOURCES" : "third_main.c", "EXE" : "a.out"})
+ self.build(dictionary={"C_SOURCES": "third_main.c", "EXE": "a.out"})
- (target, process, thread, bkpt) = lldbutil.run_to_breakpoint_do_run(self, target, bkpt)
+ (target, process, thread, bkpt) = lldbutil.run_to_breakpoint_do_run(
+ self, target, bkpt
+ )
bkpt_id = bkpt.GetID()
loc_string = f"{bkpt_id}.3"
self.runCmd(f"break disable {loc_string}")
-
``````````
</details>
https://github.com/llvm/llvm-project/pull/145994
More information about the lldb-commits
mailing list