[Lldb-commits] [lldb] [lldb] Extract debug server location code (PR #145706)

[Pavel Labath via lldb-commits]

labath wrote:

> Thanks, and sorry for not getting back to the Mac issue I said I'd debug, I've been preoccupied lately.

That's okay, no worries.

> To make sure I understand, this change hoists the logic that discovers the location of lldb-server (the function `GetDebugserverPath`) out of the unified logic of launching a debug server and up to `ProcessGDBRemote`, allowing lldb-server platform mode to supply itself as the debug server path, whereas other use cases that go through `ProcessGDBRemote` still get the old location-discovery logic, right? (which use cases are those? launching a debug server from `lldb` itself?)

That's completely correct. There are two exactly two use cases for launching lldb-gdb-server, one from (lib)lldb, and one from lldb-server-platform. This lets each implement discovery on its own (among other things).

https://github.com/llvm/llvm-project/pull/145706