[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

[Chelsea Cassanova via lldb-commits]

================
@@ -0,0 +1,22 @@
+include(CheckCXXCompilerFlag)
----------------
chelcassanova wrote:

Looking at this again, I realize that on its own this is probably unnecessary, but this include is actually here for a check of a compiler flag:

```
check_cxx_compiler_flag("-Wno-gnu-zero-variadic-macro-arguments"
  CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
```

because when building liblldbrpc, we add a compiler flag using the variable above as such:

```
if(CXX_SUPPORTS_NO_GNU_ZERO_VARIADIC_MACRO_ARGUMENTS)
  target_compile_options(liblldbrpc
    PRIVATE
      "-Wno-gnu-zero-variadic-macro-arguments")
endif()
```

>From what I'm seeing, this include here should probably stay. Removing this include alone probably wouldn't change anything about compiling, but not having the above checks for this flag would.

https://github.com/llvm/llvm-project/pull/138031