[Lldb-commits] [lldb] [lldb-dap][test] Refactor runInTerminal Tests. (PR #144954)

[Michael Buch via lldb-commits]

Michael137 wrote:

These tests are failing on the macOS sanitized bot bot. First failure started here: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/1858/execution/node/89/log/

This patch is in the changelist. @da-viper mind taking a look? Or should we skip this on ASAN?

```
12:51:48  ======================================================================
12:51:48  FAIL: test_basic_functionality (TestDAP_restart_runInTerminal.TestDAP_restart_runInTerminal)
12:51:48     Test basic restarting functionality when the process is running in
12:51:48  ----------------------------------------------------------------------
12:51:48  Traceback (most recent call last):
12:51:48    File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/packages/Python/lldbsuite/test/decorators.py", line 149, in wrapper
12:51:48      return func(*args, **kwargs)
12:51:48    File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/test/API/tools/lldb-dap/restart/TestDAP_restart_runInTerminal.py", line 46, in test_basic_functionality
12:51:48      self.build_and_launch(program, runInTerminal=True)
12:51:48    File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 488, in build_and_launch
12:51:48      return self.launch(program, **kwargs)
12:51:48    File "/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py", line 470, in launch
12:51:48      self.assertTrue(
12:51:48  AssertionError: False is not true : launch failed (process exited during launch or attach)
12:51:48  Config=arm64-/Users/ec2-user/jenkins/workspace/llvm.org/lldb-cmake-sanitized/lldb-build/bin/clang
```

https://github.com/llvm/llvm-project/pull/144954