[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

[via lldb-commits]

================
@@ -299,6 +299,8 @@ def parseOptionsAndInitTestdirs():
     configuration.libcxx_library_dir = args.libcxx_library_dir
     configuration.cmake_build_type = args.cmake_build_type.lower()
 
+    configuration.target_triple = args.target_triple
+
----------------
Nerixyz wrote:

In the MSVC toolchain on Clang, [there's an open FIXME](https://github.com/llvm/llvm-project/blob/fcd82f9cf3b64d8959afed4569259163da3a5afd/clang/lib/Driver/ToolChains/MSVC.cpp#L786) for supporting libc++. I feel hesitant changing the target there.

If I understand you correctly, then the test would check if it's running on `*-pc-windows-*` and change it to `*-pc-windows-msvc`. In which case, it assumes to always run with MSVC's STL. That could work. Clang on MinGW uses `x86_64-w64-windows-gnu` so this wouldn't get changed, which is good.

Maybe it's better to get that fixme fixed in Clang (i.e. introduce something like `-stdlib=libc++`/`-stdlib=msvcstl`). As far as I know, MSVC's STL only works on the `*-msvc` targets.

https://github.com/llvm/llvm-project/pull/143177