[Lldb-commits] [lldb] [lldb] Remove child_process_inherit argument from Pipe (PR #145516)

via lldb-commits lldb-commits at lists.llvm.org
Tue Jun 24 07:16:15 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Host/PipeBase.h lldb/include/lldb/Host/posix/PipePosix.h lldb/include/lldb/Host/windows/PipeWindows.h lldb/source/Host/common/Socket.cpp lldb/source/Host/posix/ConnectionFileDescriptorPosix.cpp lldb/source/Host/posix/MainLoopPosix.cpp lldb/source/Host/posix/PipePosix.cpp lldb/source/Host/posix/ProcessLauncherPosixFork.cpp lldb/source/Host/windows/PipeWindows.cpp lldb/source/Interpreter/ScriptInterpreter.cpp lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp lldb/source/Target/Process.cpp lldb/tools/lldb-server/lldb-gdbserver.cpp lldb/unittests/Core/CommunicationTest.cpp lldb/unittests/Host/HostTest.cpp lldb/unittests/Host/PipeTest.cpp lldb/unittests/Host/SocketTest.cpp lldb/unittests/TestingSupport/Host/PipeTestUtilities.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
index 20cd689d7..4a1394416 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
@@ -973,8 +973,9 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
       pipe_t write = socket_pipe.GetWritePipe();
       debugserver_args.AppendArgument(llvm::StringRef("--pipe"));
       debugserver_args.AppendArgument(llvm::to_string(write));
-      launch_info.AppendDuplicateFileAction((int64_t)socket_pipe.GetWritePipe(),
-                                            (int64_t)socket_pipe.GetWritePipe());
+      launch_info.AppendDuplicateFileAction(
+          (int64_t)socket_pipe.GetWritePipe(),
+          (int64_t)socket_pipe.GetWritePipe());
 #endif
     } else {
       // No host and port given, so lets listen on our end and make the

``````````

</details>


https://github.com/llvm/llvm-project/pull/145516


More information about the lldb-commits mailing list